fix AI ships getting permanently stuck after losing or refusing a target - #7736
Merged
Merged
Conversation
Goober5000
added
fix
wookieejedi
approved these changes
Aug 24, 2026
Goober5000
force-pushed
the
fix/actively_pursues
branch
4 times, most recently
from
August 24, 2026 06:12
0681467 to
bbd860c
Compare
Goober5000
marked this pull request as draft
August 25, 2026 03:51
Generalize the unreleased "$fix target updating with strafe:" ai_profiles flag into "$fix ai target recovery:", which now also covers two more ways a ship holding a standing chase order could park in AIM_NONE forever: * a ship already in AIM_NONE with a standing chase order (attack-any etc.) now clears its active goal so the order is re-processed, closing the window where retargeting finds a new enemy before the strafe clause can fire * target selection (find_enemy/get_nearest_objnum) now skips ships outside the attacker's actively-pursues list, and ai_chase() drops self-chosen targets it refuses, instead of holding a target it will never attack Retail behavior is unchanged when the flag is disabled; explicit orders on non-pursued targets are still declined as before. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Goober5000
force-pushed
the
fix/actively_pursues
branch
from
August 26, 2026 01:08
bbd860c to
b25f448
Compare
Goober5000
marked this pull request as ready for review
August 26, 2026 01:08
wookieejedi
approved these changes
Aug 26, 2026
wookieejedi
left a comment
wookieejedi
left a comment
Member
There was a problem hiding this comment.
New updates look good too
wookieejedi
pushed a commit
that referenced
this pull request
Aug 26, 2026
…get (#7736) Generalize the unreleased "$fix target updating with strafe:" ai_profiles flag into "$fix ai target recovery:", which now also covers two more ways a ship holding a standing chase order could park in AIM_NONE forever: * a ship already in AIM_NONE with a standing chase order (attack-any etc.) now clears its active goal so the order is re-processed, closing the window where retargeting finds a new enemy before the strafe clause can fire * target selection (find_enemy/get_nearest_objnum) now skips ships outside the attacker's actively-pursues list, and ai_chase() drops self-chosen targets it refuses, instead of holding a target it will never attack Retail behavior is unchanged when the flag is disabled; explicit orders on non-pursued targets are still declined as before. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
wookieejedi
added
added to point release
and removed
Point Release Candidate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generalize the unreleased "$fix target updating with strafe:" ai_profiles flag into "$fix ai target recovery:", which now also covers two more ways a ship holding a standing chase order could park in AIM_NONE forever:
Retail behavior is unchanged when the flag is disabled; explicit orders on non-pursued targets are still declined as before.
Follow-up to, and supersedes, #7619.